Skip to content

Conversation

@Abogical
Copy link
Member

@Abogical Abogical commented Oct 16, 2025

Reason for this change

OIDC is not setup in prod, and it isn't needed as we already can use the role in Codebuild to assume the Atmosphere role.

Description of changes

Use AssumeRole instead of OIDC. This is done by using AWS CLI STS directly.

No new permissions added.

A workflow has been run successfully with this configuration here: https://github.com/Abogical/aws-cdk/actions/runs/18465794651/job/52607352315?pr=15

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 16, 2025 15:06
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Oct 16, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 16, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Abogical Abogical force-pushed the integ-deploy-use-assume-role branch from b9e12e6 to 0f3493c Compare October 16, 2025 15:32
@Abogical Abogical changed the title fix(integration-test-deployment): Use AssumeRole instead of OIDC ci(integration-test-deployment): Use AssumeRole instead of OIDC Oct 16, 2025
@Abogical Abogical changed the title ci(integration-test-deployment): Use AssumeRole instead of OIDC ci(integration-test-deployment): use AssumeRole instead of OIDC Oct 16, 2025
@Abogical Abogical marked this pull request as ready for review October 16, 2025 15:35
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 16, 2025 15:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@alvazjor alvazjor self-assigned this Oct 17, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 17, 2025
@mergify mergify bot merged commit 6021130 into main Oct 17, 2025
37 of 38 checks passed
@mergify mergify bot deleted the integ-deploy-use-assume-role branch October 17, 2025 09:37
@mergify mergify bot removed the queued label Oct 17, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants