Skip to content

feat(agentcore): agentcore gateway L2 construct #35771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
Nov 20, 2025
Merged

feat(agentcore): agentcore gateway L2 construct #35771

merged 81 commits into from
Nov 20, 2025

Conversation

@dineshSajwan
Copy link
Contributor

@dineshSajwan dineshSajwan commented Oct 17, 2025 •
edited
Loading

Issue # (if applicable)

Related to aws/aws-cdk-rfcs#785

Reason for this change

Adding bedrock agent core gateway and gateway target

Description of changes

  • Added a new L2 construct for agentcore gateway
  • Added a new L2 construct for agentcore gateway target
  • Added validation helper methods, convenience method like addLambdaTarget, addOpenApiTarget, and other static methods.
  • Added integ and unit test cases

Describe any new or updated permissions being added

The gateway creates a role with permission to bedrock agentcore , s3

Description of how you validated changes

Unit tests, integration tests, manual tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

dinsajwa and others added 30 commits September 29, 2025 11:57
feat(agentcore): added runtime and endpoint
9605217
feat(runtime): added integ test
356c42d
feat(runtime): added integ test
b124520
feat(runtime): updated integ test and readme
cfad025
@dineshSajwan
Merge branch 'aws:main' into agentcore-runtime
a4cd8b7
feat(runtime): adding integ snapshot and documentation
910cf05
@dineshSajwan
Merge branch 'aws:main' into agentcore-runtime
7a306af
feat(runtime): updated doc to fix rosetta build issue
778e5b0
@dineshSajwan
Merge branch 'aws:main' into agentcore-runtime
bae6962
feat(runtime): updated docs for auth and fix issue in runtime
e301efd
feat(runtime): updated docs for auth and fix issue in runtime
150b222
feat(runtime): review comments implemented
ea39263
@dineshSajwan
Merge branch 'aws:main' into agentcore-runtime
a4a2ccf
feat(runtime): updated docs
0062054
@dineshSajwan
Merge branch 'main' into agentcore-runtime
d20e5a3
feat(runtime): removed unwanted method
4b87383
@dineshSajwan
Merge branch 'main' into agentcore-runtime
8b227b8
@dineshSajwan
Merge branch 'aws:main' into agentcore-runtime
f48b7bf
feat(runtime): added review comments and fixed integ test
3c058da
feat(agentcore): removed unwanted params from oauth
13ffd1d
feat(agentcore): updated runtime
a74054f
feat(agentcore): updated runtime with connection object
7f541d5
@dineshSajwan
Merge branch 'aws:main' into agentcore-runtime
2e18add
@dineshSajwan
Merge branch 'aws:main' into agentcore-runtime
2bd3112
feat(runtime): updated test cases
f724588
feat(agenctcore): added vpcconfig for runtime
bab3f14
@dineshSajwan
Merge branch 'main' into agentcore-runtime
028bbaa
feat(agenctcore): updated test with test account
8f1e9bb
Merge branch 'agentcore-runtime' of https://github.com/dineshSajwan/a…
7a69a05 
…ws-cdk into agentcore-runtime
feat(agenctcore): runtime review comment and new policy
3ac39ab
@mergify mergify bot dismissed alvazjor’s stale review November 18, 2025 22:05

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 18, 2025
alvazjor
alvazjor previously requested changes Nov 19, 2025
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 19, 2025
@mergify mergify bot dismissed alvazjor’s stale review November 19, 2025 15:35

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 19, 2025
alvazjor
alvazjor previously requested changes Nov 19, 2025
View reviewed changes
packages/@aws-cdk/aws-bedrock-agentcore-alpha/agentcore/gateway/perms.ts Outdated
* Used by the Gateway to manage its own resources and invoke targets
*/
export const SERVICE_ROLE_PERMS = [
'bedrock-agentcore:*Gateway*',
Copy link
Contributor

@alvazjor alvazjor Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be a bit more defensive on the permissions, can you actually add all the actions instead of using the * notation? I would like to prevent the possibility of a new unrelated action being introduced later, and we granting the permissions just because shares the name. I'd rather make it explicit.
This applies for all the actions in this file.

Copy link
Contributor Author

@dineshSajwan dineshSajwan Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 19, 2025
@mergify mergify bot dismissed alvazjor’s stale review November 19, 2025 21:31

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 19, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@alvazjor alvazjor removed the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Nov 20, 2025
@alvazjor alvazjor added the pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. label Nov 20, 2025
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Nov 20, 2025

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 07c4a0d into aws:main Nov 20, 2025
26 of 27 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumvprat kumvprat kumvprat left review comments

@alvazjor alvazjor alvazjor approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@mazyu36 mazyu36 mazyu36 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kumvprat kumvprat

@alvazjor alvazjor

Labels

p2 pr/request-cli-integ-tests Request CLI integ tests to be run. You will need to review the code and approve the deployment. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dineshSajwan @aws-cdk-automation @mazyu36 @kumvprat @alvazjor