-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(rds): add metricReadIOPs method to DatabaseClusterBase #35773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasdeepbhalla
wants to merge
6
commits into
aws:main
Choose a base branch
from
jasdeepbhalla:issue_35327_add_metricReadIOPs_method_to_DatabaseClusterBase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(rds): add metricReadIOPs method to DatabaseClusterBase #35773
jasdeepbhalla
wants to merge
6
commits into
aws:main
from
jasdeepbhalla:issue_35327_add_metricReadIOPs_method_to_DatabaseClusterBase
+411
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Oct 17, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
2 tasks
Author
|
@pahud This PR is ready for review! |
This was referenced Nov 13, 2025
38157e0 to
31788ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #35327
Closes #35327.
Reason for this change
Currently,
DatabaseClusterFromSnapshotonly exposes themetricVolumeReadIOPs()method for monitoring cluster-level I/O metrics. Users cannot easily track instance-levelReadIOPsat the cluster level, which is required for compliance monitoring (e.g., Drata) and simplifies CloudWatch alarm configuration.Description of changes
metricReadIOPs(props?: cloudwatch.MetricOptions): cloudwatch.MetrictoDatabaseClusterBase.DatabaseClusterandDatabaseClusterFromSnapshotby inheritance.metricVolumeReadIOPsandmetricACUUtilization.ReadIOPsmetric at the cluster level without manually configuring metrics for each instance.Example usage:
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license