-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(codebuild): add support for macOS 15 CodeBuild runners #35836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ayush-panta
wants to merge
7
commits into
aws:main
Choose a base branch
from
ayush-panta:add-macos15-codebuild
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65,043
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ayush-panta <ayushkp@amazon.com>
Signed-off-by: ayush-panta <ayushkp@amazon.com>
aws-cdk-automation
previously requested changes
Oct 24, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Author
|
Though the automated validation passes, I still have to add a snapshot for the base15 integration test. Update: generated and added. |
Author
|
Hello, just bumping this PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Although CodeBuild supports the macOS base:15 image (ref), the CDK does not support this.
Description of changes
I added an option for the BASE_15 image. This simply involved copying the logic for BASE_14 and changing 14 to 15.
Describe any new or updated permissions being added
NA.
Description of how you validated changes
I added unit and integration tests for the base:15 image following the example of the existing tests for the base:14 image.
Unit tests (aws-codebuild/test/project.test.ts) passed locally:
The integration tests (aws-codebuild/test/integ.project-macos-fleet-base{14/15}.js) were not as straightforward. In the CodeBuild stack logs in my console, the stacks were able to be created successfully but failed to delete. I believe this is expected with macOS fleets and for these test cases, especially as the base:14 test already existed in the codebase. I have included snapshots, as required.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license