feat(bedrock-agentcore): use IUserPool and IUserPoolClient interfaces instead of string identifiers #35860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature-request
github-actions
bot
added
the
distinguished-contributor
aws-cdk-automation
previously requested changes
Oct 27, 2025
Contributor
|
That seems to be a fair edit, thanks @mazyu36 ! |
Member
|
Thanks @mazyu36 ! Make sure to classify this as a breaking change. |
aws-cdk-automation
added
the
pr/needs-further-review
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
github-actions
bot
added
the
effort/medium
aws-cdk-automation
removed
the
pr/needs-further-review
mazyu36
force-pushed
the
feat/agentcore-cognito
branch
from
d620e86 to
6ec275e
Compare
mazyu36
changed the title
aws-cdk-automation
added
the
pr/needs-community-review
Contributor
Author
|
I struggled a bit with Rosetta, but I've completed the Construct implementation. |
badmintoncryer
approved these changes
Oct 28, 2025
aws-cdk-automation
added
pr/needs-maintainer-review
Abogical
approved these changes
Oct 29, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #35854 .
Reason for this change
Improve the Cognito authorizer configuration by accepting Cognito construct references instead of string identifiers, providing better type safety and integration with the CDK ecosystem.
Additionally, add support for multi-clients.
Description of changes
RuntimeAuthorizerConfiguration.usingCognito()to acceptIUserPoolandIUserPoolClientconstructs instead of string parametersThe implementation now provides better CDK integration and type safety by using construct references rather than raw string identifiers.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Add unit tests and integ test.
BREAKING CHANGE: The signature of
RuntimeAuthorizerConfiguration.usingCognito()has changed to accept IUserPool and IUserPoolClient constructs instead of string parameters, and now supports multiple clients.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license