-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: reapply refactoring for L1 resource relationships #35884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This applies the code for L1 resource relationships, originally applied in #35713 and reverted in #35832. The reason is that another PR is also making changes in this area, branched in between the original application and its revert, and is now experiencing severe merge conflicts. In this PR, reintroduce the large refactorings made in the original PR, but disable their application via a boolean flag.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
This applies the code for L1 resource relationships, originally applied in #35713 and reverted in #35832.
The reason is that another PR is also making changes in this area, branched in between the original application and its revert, and is now experiencing severe merge conflicts.
In this PR, reintroduce the large refactorings made in the original PR, but disable their application by making the list of services we apply the relationships to empty.
There were some changes to L2s in the original PR that are not included in this PR; they will need to be reapplied when restoring the feature.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license