chore(bedrock-agentcore): use UnscopedValidationError instead of Error #35889
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
distinguished-contributor
Contributor
|
Thanks @mazyu36 ! I am planning on refactoring all the validation methods as per the comments on the memory PR since we have duplicates in the agentcore folders, and I am planning to address this. Is it ok with you ? I can tag you in the PR when it's open to contribute |
Contributor
Author
|
@krokoko Thanks. It's OK. I’ll close this PR :) |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should use TypedError instead of untyped error.
Relates to #32569
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license