fix(aws-amplify-alpha) Omit Prefix from SubDomainSettings when empty string is provided #35963
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #35958
Reason for this change
After deploying a CDK stack containing an Amplify app with a custom domain that has a blank prefix, the underlying CloudFormation stack is immediately in "drifted" state.
Description of changes
Per the suggestions in the issue, I updated the
renderSubDomainSettingsmethod to omit thePrefixmethod from the resulting map when the supplied prefix is set to''.The existing fallback logic is preserved for falling back to
branchNameifprefixisnullorundefined.Describe any new or updated permissions being added
None.
Description of how you validated changes
Updated the corresponding test for mapping a branch to the domain root.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license