Skip to content

Conversation

@mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Nov 7, 2025

Issue # (if applicable)

N/A

Reason for this change

Some Validation logics were throwing unexpected errors when properties are defined as CDK Token types.
string or number may be Token.

Description of changes

  • Added Token type checking before property validation
  • Added test cases for Token properties to verify not throwing errors.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added unit tests to verify Token properties bypass validation

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 7, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 7, 2025 09:03
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Nov 7, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 7, 2025

Exemption Request: only added Token checks, so I think additional integ tests are not needed.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 7, 2025
@mazyu36 mazyu36 changed the title fix(bedrock-agentcore-alpha): fix unexpected validation error whenproperties are Token fix(bedrock-agentcore-alpha): fix unexpected validation error whenproperties are Token Nov 7, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 7, 2025
@mazyu36 mazyu36 changed the title fix(bedrock-agentcore-alpha): fix unexpected validation error whenproperties are Token fix(bedrock-agentcore-alpha): fix unexpected validation error when properties are Token Nov 7, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 7, 2025
kumsmrit
kumsmrit previously approved these changes Nov 11, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 11, 2025
@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 14, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/integration-test-deployment.yml without workflows permission

@mazyu36 mazyu36 changed the title fix(bedrock-agentcore-alpha): fix unexpected validation error when properties are Token fix(bedrock-agentcore-alpha): fix unexpected validation error when properties are Token Nov 15, 2025
@alvazjor
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

refresh

✅ Pull request refreshed

@alvazjor alvazjor added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Nov 19, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 19, 2025 16:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

alvazjor
alvazjor previously approved these changes Nov 19, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codebuild-pr-build.yml without workflows permission.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@alvazjor
Copy link
Contributor

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot dismissed stale reviews from kumsmrit and alvazjor November 19, 2025 16:04

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 084b736 into aws:main Nov 19, 2025
21 of 22 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2025
@alvazjor alvazjor self-assigned this Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants