-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(bedrock-agentcore-alpha): fix unexpected validation error when properties are Token #35978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…operties are Token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
Exemption Request: only added Token checks, so I think additional integ tests are not needed. |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated
You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
Some Validation logics were throwing unexpected errors when properties are defined as CDK
Tokentypes.stringornumbermay beToken.Description of changes
Tokentype checking before property validationTokenproperties to verify not throwing errors.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added unit tests to verify
Tokenproperties bypass validationChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license