-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(cloudfront): add missing regions to PRICE_CLASS_200 documentation #36039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(cloudfront): add missing regions to PRICE_CLASS_200 documentation #36039
Conversation
Include India, Indonesia, Thailand, Malaysia, Vietnam, Nigeria, Egypt, and Türkiye in the PRICE_CLASS_200 JSDoc comment to accurately reflect all regions covered by this price class. Closes aws#35992 Signed-off-by: SACHIN KUMAR <mrmister680@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
|
||||||||||||||
|
||||||||||||||
|
Hi @pahud ! Exemption Request: Documentation-only change updating the JSDoc comment for Please review when possible. Fixes #35992. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@sAchin-680 I am not eligible to review PRs but I can make sure your PR is ready and move into the queue.
Do you have the AWS docs link? If yes, can you include in the PR description as this will help the maintainer give a very quick approval. |
|
Thank you. I can confirm that this PR is now in the pr/needs-community-review queue. Once it receives an approving community review, it will move to the pr/needs-maintainer-review stage. Please ensure that the CI status remains in a Success state, as the maintainer will review it from that queue. |
Thank you, @pahud! Yes, the official AWS CloudFront pricing documentation link is: I believe this is the correct reference, but please correct me if I’m wrong. |
Issue # (if applicable)
Closes #35992
Reason for this change
The JSDoc comment for
PRICE_CLASS_200was missing several regions that are actually included in this price class according to the official AWS CloudFront pricing documentation, causing confusion for developers about which regions are covered.Description of changes
Updated the JSDoc comment for
PRICE_CLASS_200inpackages/aws-cdk-lib/aws-cloudfront/lib/distribution.tsto include the missing regions: India, Indonesia, Thailand, Malaysia, Vietnam, Nigeria, Egypt, and Türkiye.This is a documentation-only change that adds accurate region information to help developers understand the full scope of PRICE_CLASS_200 coverage.
Reference: AWS CloudFront Pricing — This page lists all regions included in each price class.
Describe any new or updated permissions being added
None - this is a documentation-only change.
Description of how you validated changes
distribution.test.ts) validates the enum valueChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license