Skip to content

Conversation

@pahud
Copy link
Contributor

@pahud pahud commented Nov 14, 2025

Issue

Closes #36056

Summary

Adds support for R8GD (Graviton4-based) instance types in OpenSearch Service domains by updating validation logic to recognize R8GD instances as having local NVMe storage, eliminating the requirement for EBS volumes.

Reason for this change

When attempting to create an OpenSearch domain with R8GD instance types (e.g., r8gd.medium.search), CDK throws a validation error requiring EBS volumes. However, R8GD instances have local NVMe storage (indicated by the "d" suffix) and should not require EBS volumes, similar to other instance families like R6GD, R7GD, I3, I4G, I4I, I8G, and IM4GN.

AWS announced R8GD instance availability for OpenSearch Service in October 2025 across 23 regions, but CDK's validation logic was not updated to recognize these new Graviton4-based instances.

Description of changes

  • Core Change: Added ec2.InstanceClass.R8GD to the unSupportEbsInstanceType array in domain.ts
  • Unit Tests: Updated parameterized tests to include R8GD test cases for both positive (no EBS) and negative (with EBS) scenarios
  • Error Messages: Updated validation error message patterns to include R8GD
  • Integration Tests: Added R8GD test case to integ.opensearch.ebs.ts for CloudFormation synthesis validation

Files Modified

  1. packages/aws-cdk-lib/aws-opensearchservice/lib/domain.ts - Added R8GD to validation array
  2. packages/aws-cdk-lib/aws-opensearchservice/test/domain.test.ts - Updated unit tests with R8GD cases
  3. packages/@aws-cdk-testing/framework-integ/test/aws-opensearchservice/test/integ.opensearch.ebs.ts - Added integration test

Description of how you validated changes

  • Unit Tests: All 1736 unit tests pass, including 30 R8GD-specific test cases
    • Verified error thrown when R8GD used WITH EBS enabled
    • Verified no error when R8GD used WITHOUT EBS enabled
    • Validated error messages include "R8GD" in validation text
  • Integration Tests: CloudFormation template synthesis validated with R8GD instance type
  • Pattern Validation: Follows exact pattern from R7GD addition (commit e364d2b)
  • Regression Testing: No impact on existing instance type validation

Checklist


AWS CDK Automation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

- Update integration test for OpenSearch Domain with instance store configuration
- Add new test case for r8gd instance type with EBS disabled
- Update snapshot files and integration test metadata
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Nov 14, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2025 05:49
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 14, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kumsmrit kumsmrit self-assigned this Nov 14, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 82420f0 into aws:main Nov 14, 2025
19 of 20 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-opensearchservice/domain: r8gd not usable

2 participants