Skip to content

feat(route53): add HostedZoneGrants #36109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
Nov 21, 2025
Merged

feat(route53): add HostedZoneGrants #36109

mergify merged 2 commits into from
Nov 21, 2025

Conversation

@otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented Nov 19, 2025

Create a new class, HostedZoneGrants, that has all the grants methods, and delegate the grantDelegation() method in all implementations of IHostedZone to it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 19, 2025 17:14
@github-actions github-actions bot added the p2 label Nov 19, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 19, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Nov 20, 2025
rix0rrr
rix0rrr approved these changes Nov 20, 2025
View reviewed changes
packages/aws-cdk-lib/aws-route53/lib/hosted-zone-ref.ts
import { IHostedZoneRef } from '../../interfaces/generated/aws-route53-interfaces.generated';

export interface INamedHostedZoneRef extends IHostedZoneRef {
readonly name: string;
Copy link
Contributor

@rix0rrr rix0rrr Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not zoneName: string which already exists?

Copy link
Contributor Author

@otaviomacedo otaviomacedo Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that CfnHostedZone automatically implements this interface.

@otaviomacedo otaviomacedo added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr/do-not-merge This PR should not be merged at this time. labels Nov 21, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 21, 2025 08:07

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d24305c into main Nov 21, 2025
18 of 19 checks passed
@mergify mergify bot deleted the otaviom/route53-grants branch November 21, 2025 08:45
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@otaviomacedo @rix0rrr @aws-cdk-automation