Skip to content

Conversation

@Abogical
Copy link
Member

Reason for this change

Error handling

The following new properties to Kafka based ESM for error handling is now supported:

  • BisectBatchOnFunctionError
  • MaximumRetryAttempts
  • MaximumRecordAgeInSeconds
  • FunctionResponseTypes

Poll grouping

Add support for multi esm grouping which can allow customers optimize for cost by sharing compute.
This will only be supported for Kafka based ESMs in provisioned mode. This support is added via the new property ProvisionedPollerConfig

Failure destination

Allow customers to send failed records to a kafka topic using on failure destination. We'll be supporting same cluster as the event source.

Description of changes

  • Adds the new properties mentioned above.
  • For setting failure destination:
    • Created a new kafka-dlq file to support new destination
    • Customers can either define topicName or kafka://topic as input.
    • Added unit tests and integration tests.

Describe any new or updated permissions being added

No new permissions are added.

Description of how you validated changes

Verified through integration and unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Nov 24, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 24, 2025 07:56
@Abogical Abogical added priority-pr push the PR to priority squash queue and removed p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Nov 24, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 24, 2025
@Abogical Abogical added the pr/auto-approve Notifies the GH action to auto-approve this PR label Nov 24, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 24, 2025
@Abogical Abogical removed the pr/auto-approve Notifies the GH action to auto-approve this PR label Nov 24, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Abogical Abogical added the pr/do-not-merge This PR should not be merged at this time. label Nov 24, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #36164 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • -label~=(blocked|do-not-merge|no-squash|two-approvers)
  • check-success=build
  • check-success=validate-pr
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue priority-squash]
      • -label~=(blocked|do-not-merge|no-squash)
      • check-success=build
      • check-success=validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-neutral = validate-pr
        • check-skipped = validate-pr
        • check-success = validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build
        • check-skipped = build
        • check-success = build.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Abogical Abogical closed this Nov 24, 2025
@Abogical Abogical deleted the lambda-esm-consolidated-squashed branch November 24, 2025 09:17
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time. priority-pr push the PR to priority squash queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants