Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 25, 2025

Issue # (if applicable)

Closes #.

Reason for this change

Deploying multiple LogDeliverys was not possible due to various naming conflicts. This change introduces a more consistent naming schema for all Construct Ids and names that will allow using multiple LogDeliverys in the same app.

Description of changes

Simplified and unified naming of the created resources.
Also fixed some dependencies that were missing on the policies.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Integ test added.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 25, 2025 16:15
@github-actions github-actions bot added the p2 label Nov 25, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 25, 2025
@mrgrain mrgrain changed the title chore(mixins-preview): vended logs integ test fix(mixins-preview): ResourcePolicy with this name already exists error when setting up LogDelivery Nov 25, 2025
@mrgrain mrgrain force-pushed the mrgrain/chore/vended-logs-integ branch 3 times, most recently from 4a0e405 to 961e08a Compare November 25, 2025 22:32
@mrgrain mrgrain force-pushed the mrgrain/chore/vended-logs-integ branch from 961e08a to ff2da42 Compare November 25, 2025 22:59
@mrgrain mrgrain marked this pull request as ready for review November 25, 2025 22:59
@mrgrain mrgrain force-pushed the mrgrain/chore/vended-logs-integ branch from ff2da42 to 7459b35 Compare November 26, 2025 00:08
@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 4 seconds in the queue, with no time waiting for CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f9aa31d into main Nov 26, 2025
17 of 18 checks passed
@mergify mergify bot deleted the mrgrain/chore/vended-logs-integ branch November 26, 2025 00:37
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants