Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 25, 2025

Issue # (if applicable)

@aws-cdk.mixins-preview.aws_logs.S3LogsDelivery-example.ts:19:3 - error TS2322: Type '"permissionsVersion"' is not assignable to type '"V1" | "V2" | undefined'.

19   permissionsVersion: 'permissionsVersion',
     ~~~~~~~~~~~~~~~~~~
@aws-cdk.mixins-preview.aws_logs.S3LogsDeliveryProps-example.ts:16:3 - error TS2322: Type '"permissionsVersion"' is not assignable to type '"V1" | "V2" | undefined'.

16   permissionsVersion: 'permissionsVersion',
     ~~~~~~~~~~~~~~~~~~

  /codebuild/output/src37859859/src/packages/@aws-cdk/mixins-preview/lib/services/aws-logs/logs-delivery.ts:54:12
    54   readonly permissionsVersion?: 'V1' | 'V2';
                  ~~~~~~~~~~~~~~~~~~
    The expected type comes from property 'permissionsVersion' which is declared here on type 'S3LogsDeliveryProps'
[jsii-rosetta] [WARN] 2 diagnostics from assemblies with 'strict' mode on (and 368 more non-strict diagnostics)

Reason for this change

String literal types are not allowed in our pipeline.

Description of changes

Replaced the string literal type with an enum.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Existing tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 25, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 25, 2025 19:08
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 25, 2025
@Abogical Abogical added the pr/do-not-merge This PR should not be merged at this time. label Nov 25, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 25, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 25, 2025 19:11

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain mrgrain force-pushed the mrgrain/fix/permissionsVersion branch from cbe7f9c to 15a22ef Compare November 25, 2025 19:15
@Abogical Abogical removed the pr/do-not-merge This PR should not be merged at this time. label Nov 25, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 5 seconds in the queue, with no time waiting for CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cc491df into main Nov 25, 2025
23 of 24 checks passed
@mergify mergify bot deleted the mrgrain/fix/permissionsVersion branch November 25, 2025 19:54
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants