-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(mixins-preview): cannot use string literal types for S3LogsDeliveryProps.permissionsVersion
#36197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/@aws-cdk/mixins-preview/lib/services/aws-logs/logs-delivery.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…ryProps.permissionsVersion
cbe7f9c to
15a22ef
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Reason for this change
String literal types are not allowed in our pipeline.
Description of changes
Replaced the string literal type with an enum.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license