-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(ecs-patterns): target group ID changes without setting feature flag #36199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
There seems to be a bug with the deployment integ runner, cancelling workflow and deploying locally instead. The workflow will not block the merge. |
|
Test snapshots deployed successfully on the local machine. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #36149
Reason for this change
The feature flag did not stop the target group ID of the ALB to change if the load balancer was private.
Description of changes
The target group ID will not change if the feature flag is not set and remain as
ECS.Describe any new or updated permissions being added
No new permissions are added.
Description of how you validated changes
Unit test added.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license