chore(merge-back): 2.230.0 #36219
Merged
chore(merge-back): 2.230.0 #36219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Issue # (if applicable)
Closes #<issue number here>.
### Reason for this change
Remove the detail interface that was extending the
`cdk.AWSEventMetadataProps` as extending creates problems in python.
### Description of changes
Before
```
export interface ObjectCreatedDetail {
readonly bucket?: BucketEvents.ObjectCreated.Bucket;
...otherfields
}
export interface PatternProps extends BucketEvents.ObjectCreated.ObjectCreatedDetail {
readonly eventMetadata?: cdk.AWSEventMetadataProps;
}
```
After this change:
```
export interface ObjectCreatedProps {
readonly eventMetadata?: cdk.AWSEventMetadataProps;
readonly bucket?: BucketEvents.ObjectCreated.Bucket;
...otherfields
}
```
The Pattern functions have been updated to:
```
public workSpacesAccessPattern(options?: WorkspaceEvents.WorkSpacesAccess.WorkSpacesAccessProps): events.EventPattern {
return {
source: ["aws.workspaces"],
detailType: ["WorkSpaces Access"],
detail: convertWorkSpacesAccessDetailToEventPattern(options, this.workspaceRef),
version: options?.eventMetadata?.version,
resources: options?.eventMetadata?.resources,
region: options?.eventMetadata?.region
};
}
```
And the `convertWorkSpacesAccessDetailToEventPattern` functions ignore
the `eventMetadata` property.
### Describe any new or updated permissions being added
<!-- What new or updated IAM permissions are needed to support the
changes being introduced? -->
### Description of how you validated changes
<!-- Have you added any unit tests and/or integration tests? Did you
test by hand? -->
Added unit test to ensure that the metadata was still being passed to
the `EventPattern`
### Checklist
- [X] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
Co-authored-by: Leon Michalski <leonmk@amazon.de>
aws-cdk-automation
added
auto-approve
pr/no-squash
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aws-cdk-automation
added
the
pr/needs-maintainer-review
Contributor
Merge Queue Status
✅ The pull request has been merged This pull request spent 6 seconds in the queue, with no time waiting for CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG