fix(route53): add vpce:AllowMultiRegion permission to VpcEndpointServiceDomainName #36221
+1,775
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
aws-cdk-automation
requested changes
Nov 26, 2025
Collaborator
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-further-review
tiagoq
force-pushed
the
fix/vpc-endpoint-service-domain-name-cross-region
branch
from
c64db56 to
892f005
Compare
1 task
…iceDomainName When using VpcEndpointServiceDomainName with a VpcEndpointService that has cross-region PrivateLink enabled via allowedRegions, the custom resource Lambda fails because the IAM policy is missing the vpce:AllowMultiRegion permission. This change updates the EnableDns custom resource to use an explicit policy with both ec2:ModifyVpcEndpointServiceConfiguration and vpce:AllowMultiRegion permissions, scoped to the specific VPC endpoint service resource. Fixes aws#36216
tiagoq
force-pushed
the
fix/vpc-endpoint-service-domain-name-cross-region
branch
from
892f005 to
ed4df80
Compare
aws-cdk-automation
removed
the
pr/needs-further-review
Contributor
|
For some reason, it's blocked by this. I am hitting the update branch button and see if it unblocks itself.
|
aws-cdk-automation
added
pr/reviewer-clarification-requested
pahud
removed
the
pr-linter/exemption-requested
Contributor
|
OK looks like the linter expects this PR to have change on |
aws-cdk-automation
added
pr-linter/exemption-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36216
When using
VpcEndpointServiceDomainNamewith aVpcEndpointServicethat has cross-region PrivateLink enabled viaallowedRegions, the custom resource Lambda fails with:This PR adds the
vpce:AllowMultiRegionpermission to the custom resource policy. The permission is always included since:Changes
packages/aws-cdk-lib/aws-route53/lib/vpc-endpoint-service-domain-name.ts:aws-iamimportAwsCustomResourcePolicy.fromSdkCalls()toAwsCustomResourcePolicy.fromStatements()for theEnableDnscustom resourceec2:ModifyVpcEndpointServiceConfigurationandvpce:AllowMultiRegionactions to the policypackages/aws-cdk-lib/aws-route53/test/vpc-endpoint-service-domain-name.test.tsTesting
All 264 tests pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license