-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: make build more efficient by running tests as .js #36254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rix0rrr
wants to merge
10
commits into
main
Choose a base branch
from
huijbers/run-tests-as-js
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+638
−1,950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2f490b to
7d6f3e6
Compare
Contributor
|
||||||||||||||
Contributor
|
||||||||||||||
93f5b64 to
afc1ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now running every test file through
ts-jest, which means all TypeScriptcode gets parsed again and again for every test.
Instead, in this PR we run our tests in 2 different ways:
Needs some related changes to the tests to make it all work out properly:
*.ts.snap(not sometimes*.ts.snapand sometimes*.js.snap)babel-jestso that mock hoisting still works.jest.mock()implicit global in order for mock hoisting to work withbabel-jest, so can't have explicit imports.cx-apiwas not compiling its tests so we couldn't run.jstests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license