chore(spec2cdk): refactor to use hand-written helpers for arrays #36256
+48
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
The previously generated code for getting the values of the
IxxRefin arrays was not readable, as a for loop to mutate the array in place and comma syntax were used to return the mutated array in a single line.Before:
After:
Description of changes
Added a handwritten function to do the in place in mapping in a generic way, preserving type safety.
Description of how you validated changes
aws-cdk/packages/aws-cdk-lib/aws-lambda/test/function.test.ts
Line 5246 in 3e048c1
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license