Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 2, 2025

Centralize eslint config in a new package, @aws-cdk/eslint-config as well because it was duplicated too much.

Addresses linting/compilation problems that had gone unnoticed because of nonstandard package configs.

  • Rename .eslintrc.js -> eslint.config.js everywhere for the new flat config (and update .gitignore and .npmignore at the same time)
  • Introduce @aws-cdk/eslint-config to hold a centralized config for all packages in the monorepo.
  • Found some .bak files that seem like they're just hanging out.
  • Update all packages with eslint --fix to the new sets of rules.
  • Custom resource handler tests were not being type checked and had a bunch of issues that needed to be fixed.
  • quote-props -> @stylistic/quote-props
  • Bulk suppressions for the Error rule in dedicated files, because the eslint tool doesn't allow adding suppression comments in bulk.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team December 2, 2025 13:22
@aws-cdk-automation aws-cdk-automation requested a review from a team December 2, 2025 13:22
@github-actions github-actions bot added the p2 label Dec 2, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 2, 2025
@rix0rrr rix0rrr requested a review from a team as a code owner December 2, 2025 15:58
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Manual changes to the classes.ts file are not allowed.
❌ Manual changes to the enums.ts file are not allowed.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants