-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: upgrade to new eslint and switch to flat config #36272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Manual changes to the classes.ts file are not allowed.
❌ Manual changes to the enums.ts file are not allowed.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Centralize eslint config in a new package,
@aws-cdk/eslint-configas well because it was duplicated too much.Addresses linting/compilation problems that had gone unnoticed because of nonstandard package configs.
.eslintrc.js->eslint.config.jseverywhere for the new flat config (and update.gitignoreand.npmignoreat the same time)@aws-cdk/eslint-configto hold a centralized config for all packages in the monorepo..bakfiles that seem like they're just hanging out.eslint --fixto the new sets of rules.quote-props->@stylistic/quote-propsErrorrule in dedicated files, because the eslint tool doesn't allow adding suppression comments in bulk.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license