Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): force deployment bucket to be private #3695

Merged
merged 1 commit into from
Aug 18, 2019
Merged

feat(cli): force deployment bucket to be private #3695

merged 1 commit into from
Aug 18, 2019

Conversation

hoegertn
Copy link
Contributor

This change forces the toolkit bucket to be private. There is no need for it to be public so for safety reasons we enforce this.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@eladb eladb changed the title feat(bootstrap): force toolkit bucket private feat(cli): force toolkit bucket private Aug 18, 2019
@eladb eladb changed the title feat(cli): force toolkit bucket private feat(cli): force deployment bucket to be private Aug 18, 2019
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit d1ee4ba into aws:master Aug 18, 2019
@hoegertn hoegertn deleted the private-toolkit-bucket branch August 18, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants