Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3-deployment): optional role override for bucket-deployment #4284

Merged
merged 4 commits into from
Oct 10, 2019
Merged

feat(s3-deployment): optional role override for bucket-deployment #4284

merged 4 commits into from
Oct 10, 2019

Conversation

DavidChristiansen
Copy link
Contributor

@DavidChristiansen DavidChristiansen commented Sep 28, 2019 •
edited
Loading

Resolves #4281

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@DavidChristiansen DavidChristiansen changed the title #4281 - PR - Optional role override to bucket-deployment Optional role override to bucket-deployment Sep 28, 2019
@DavidChristiansen DavidChristiansen changed the title Optional role override to bucket-deployment feat(aws-s3-deployment) : Optional role override to bucket-deployment Sep 28, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously approved these changes Oct 7, 2019
View reviewed changes
@mergify mergify bot dismissed eladb’s stale review October 7, 2019 10:42

Pull request has been modified.

@DavidChristiansen DavidChristiansen changed the title feat(aws-s3-deployment) : Optional role override to bucket-deployment feat:(aws-s3-deployment) : Optional role override to bucket-deployment Oct 7, 2019
@DavidChristiansen DavidChristiansen changed the title feat:(aws-s3-deployment) : Optional role override to bucket-deployment feat(aws-s3-deployment): Optional role override to bucket-deployment Oct 7, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@DavidChristiansen DavidChristiansen force-pushed the davidchristiansen/4281-s3Deployment-CustomRole branch from 46cc5e9 to 83c8966 Compare October 7, 2019 17:11
@DavidChristiansen
Copy link
Contributor Author

Rebased to master

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously approved these changes Oct 9, 2019
View reviewed changes
@mergify mergify bot dismissed eladb’s stale review October 9, 2019 13:18

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title feat(aws-s3-deployment): Optional role override to bucket-deployment feat(s3-deployment): optional role override for bucket-deployment Oct 10, 2019
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e1b48bc into aws:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(s3deploy.BucketDeployment): Allow IAM Role override
3 participants
@DavidChristiansen @aws-cdk-automation @eladb