Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudmap): fix CloudMap Service import, expose ECS CloudMap Service #4313

Merged
merged 5 commits into from
Oct 4, 2019
Merged

fix(cloudmap): fix CloudMap Service import, expose ECS CloudMap Service #4313

merged 5 commits into from
Oct 4, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 1, 2019

  • Fix the missing initialization of namespace on CloudMap's
    Service.fromServiceAttributes().
  • Expose the created CloudMap Service on ECS services so that
    fromServiceAttributes() doesn't need to be called at all.
  • Fix a number of property initialization errors across the library.

Fixes #4286.

BREAKING CHANGE: cloudmap.Service.fromServiceAttributes takes a newly
required argument namespace.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
fix(cloudmap): fix CloudMap Service import, expose ECS CloudMap Service
2839782 
- Fix the missing initialization of `namespace` on CloudMap's
  `Service.fromServiceAttributes()`.
- Expose the created CloudMap Service on ECS services so that
  `fromServiceAttributes()` doesn't need to be called at all.
- Fix a number of property initialization errors across the library.

Fixes #4286.

BREAKING CHANGE: `cloudmap.Service.fromServiceAttributes` takes a newly
required argument `namespace`.
@rix0rrr rix0rrr requested a review from SoManyHs as a code owner October 1, 2019 10:41
@rix0rrr rix0rrr self-assigned this Oct 1, 2019
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Oct 1, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller
RomainMuller reviewed Oct 2, 2019
View reviewed changes
packages/@aws-cdk/aws-appmesh/lib/virtual-router.ts
@@ -174,7 +181,7 @@ export class VirtualRouter extends VirtualRouterBase {
/**
* Interface with properties ncecessary to import a reusable VirtualRouter
*/
interface VirtualRouterAttributes {
export interface VirtualRouterAttributes {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that becomes exported, but was not before... Should it be explicitly marked @experimental? Or is the whole module experimental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module is experimental. I also added fromAttributes which is new, needs this type to be public.

packages/@aws-cdk/aws-codebuild/lib/project.ts
@@ -175,7 +175,7 @@ abstract class ProjectBase extends Resource implements IProject {
* May be unset, in which case this Project is not configured to use a VPC.
* @internal
*/
protected _connections: ec2.Connections;
protected _connections: ec2.Connections | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not _connections?: ec2.Connections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason. I like the explicitness of this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the ? operator, only because it's consistent with everywhere else.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr merged commit c968c96 into master Oct 4, 2019
@rix0rrr rix0rrr deleted the huijbers/appmesh-init branch October 4, 2019 09:34
@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller left review comments

@nija-at nija-at nija-at approved these changes

@skinny85 skinny85 Awaiting requested review from skinny85

@eladb eladb Awaiting requested review from eladb

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppMesh VirtualNode creation fails due to broken servicediscovery.Service.from_service_attributes call
5 participants
@rix0rrr @aws-cdk-automation @RomainMuller @nija-at @SomayaB