chore(deps): bump aws-sdk from 2.545.0 to 2.547.0 #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
requested review from
eladb,
garnaat,
nija-at,
RomainMuller,
shivlaks and
skinny85
as code owners
dependabot-preview
bot
added
the
dependencies
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
approved these changes
Oct 11, 2019
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.545.0 to 2.547.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.545.0...v2.547.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
dependabot-preview
bot
force-pushed
the
dependabot/npm_and_yarn/aws-sdk-2.547.0
branch
from
6ee7fc6 to
21b5ccc
Compare
dependabot-preview
bot
deleted the
dependabot/npm_and_yarn/aws-sdk-2.547.0
branch
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
pushed a commit
that referenced
this pull request
Nov 27, 2019
When adding dependencies of any kind (`node.addDependency`, `stack.addDependency` or `cfnResource.addDependsOn`), we now take nested stacks into account and transfer the dependency to the lowest common scope (either a common stack or the assembly). This is primarily implemented in `cfnResource.addDependsOn` and `stack.addDependency` through the following algorithm: - Lookup the lowest common stack - If not found, apply the dependency at the assembly level (between two top-level stacks). - If found, identify the two CloudFormation resources which represent this relationship within the scope of the common stack (this could be the actual resource if they are both in the same stack or the `AWS::CloudFormation::Stack` resource if the source or target are with in a nested stack). - Apply the dependency at the CloudFormation level (add `DependsOn`). There are a bunch of edge cases as well. To be able to find the AWS::CloudFormation::Stack resource for nested stacks, the `nestedStackResource` property was added to `core.Stack` and assigned by `NestedStack`. It seems like we should probably move `NestedStack` from the `aws-cloudformation` module and into `core` since there is too much coupling right now. Created a thorough test suite to examine various cases under `test.deps.ts`. Note that this suite includes tests for nested stacks and for regular cases, but decided to put them all in a single suite to make it easier to reason about coverage. Fixes #4460
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2019
* fix(cloudformation): dependencies across nested stack boundaries When adding dependencies of any kind (`node.addDependency`, `stack.addDependency` or `cfnResource.addDependsOn`), we now take nested stacks into account and transfer the dependency to the lowest common scope (either a common stack or the assembly). This is primarily implemented in `cfnResource.addDependsOn` and `stack.addDependency` through the following algorithm: - Lookup the lowest common stack - If not found, apply the dependency at the assembly level (between two top-level stacks). - If found, identify the two CloudFormation resources which represent this relationship within the scope of the common stack (this could be the actual resource if they are both in the same stack or the `AWS::CloudFormation::Stack` resource if the source or target are with in a nested stack). - Apply the dependency at the CloudFormation level (add `DependsOn`). There are a bunch of edge cases as well. To be able to find the AWS::CloudFormation::Stack resource for nested stacks, the `nestedStackResource` property was added to `core.Stack` and assigned by `NestedStack`. It seems like we should probably move `NestedStack` from the `aws-cloudformation` module and into `core` since there is too much coupling right now. Created a thorough test suite to examine various cases under `test.deps.ts`. Note that this suite includes tests for nested stacks and for regular cases, but decided to put them all in a single suite to make it easier to reason about coverage. Fixes #4460 * validate #4474 * combine stack and resource deps into a single algorithm - Rewrote the `addDependency` algorithm generically to support defining dependencies between two resources or two stacks. - Added a cache for `Stack.of` which is expected to have some nice gains since this method is widely used, especially around these algorithms. * rename `parentStack` to `nestedStackParent` * hide the Stack.of cache property * convert nestedStackParent to a getter * fix compilation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps aws-sdk from 2.545.0 to 2.547.0.
Release notes
Sourced from aws-sdk's releases.
Changelog
Sourced from aws-sdk's changelog.
Commits
34cc60eUpdates SDK to v2.547.02a86ed2Updates SDK to v2.546.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @RomainMuller.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.ymlfile in this repo: