Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): add service name to queue processing service properties #4505

Merged
merged 9 commits into from
Oct 23, 2019
Merged

feat(ecs-patterns): add service name to queue processing service properties #4505

merged 9 commits into from
Oct 23, 2019

Conversation

pkspks
Copy link

@pkspks pkspks commented Oct 15, 2019 •
edited by piradeepk
Loading

Add ServiceName to QueueProcessingServiceBase to allow QueueProcessingEc2Service and QueueProcessingFargateService to support custom service names when constructing the service.

Use Case
Service names provide visual sorting and filtering when dealing with a large number of services in a cluster in the console.

Fixes #4504

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@pkspks pkspks requested a review from SoManyHs as a code owner October 15, 2019 03:05
@pkspks pkspks changed the title Add support for specifying ECS service name in queue processing ECS service constructs Add support for custom ECS service name in queue processing ECS service constructs Oct 15, 2019
@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@pkspks pkspks changed the title Add support for custom ECS service name in queue processing ECS service constructs feat(ecs-patterns): add support for custom ECS service name in queue processing ECS service constructs Oct 15, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Oct 15, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

piradeepk
piradeepk previously requested changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to address this issue.

@piradeepk piradeepk changed the title feat(ecs-patterns): add support for custom ECS service name in queue processing ECS service constructs feat(ecs-patterns): add service name to queue processing service properties Oct 22, 2019
@piradeepk piradeepk added @aws-cdk/aws-ecs-patterns Related to ecs-patterns library and removed @aws-cdk/aws-ecs Related to Amazon Elastic Container labels Oct 22, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot dismissed piradeepk’s stale review October 22, 2019 23:53

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pkspks pkspks requested a review from piradeepk October 23, 2019 01:46
piradeepk
piradeepk approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! Thanks for taking the time to resolve this issue!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3202720 into aws:master Oct 23, 2019
@pkspks pkspks deleted the features/ecs-patterns-queue-processing-servicename branch October 23, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piradeepk piradeepk piradeepk approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for service name for queue processing ECS services
5 participants
@pkspks @aws-cdk-automation @piradeepk @SomayaB @SoManyHs