Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(apigateway): minor cors followups #4560

Merged
merged 1 commit into from
Oct 17, 2019
Merged

chore(apigateway): minor cors followups #4560

merged 1 commit into from
Oct 17, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Oct 17, 2019

  • Explicitly define Cors.ALL_ORIGINS and document how it can be used in allowOrigins
  • Add a private constructor to Cors since it's a utility class
  • Switch up the README to start with the common case to enable CORS for all origins on the entire API.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

chore(apigateway): minor cors followups
c217e03 
* Explicitly define `Cors.ALL_ORIGINS` and document how it can be used in `allowOrigins`
* Add a private constructor to `Cors` since it's a utility class
* Switch up the README to start with the common case to enable CORS for all origins on the entire API.
@eladb eladb requested a review from nija-at as a code owner October 17, 2019 12:34
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit b9a1703 into master Oct 17, 2019
@mergify mergify bot deleted the benisrae/cors-followups branch October 17, 2019 14:35
@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 14, 2019
@sumodgeorge sumodgeorge mentioned this pull request May 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eladb @aws-cdk-automation @nija-at @SomayaB