Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(route53): use static HostedZone #4593

Merged
merged 4 commits into from
Oct 28, 2019
Merged

fix(route53): use static HostedZone #4593

merged 4 commits into from
Oct 28, 2019

Conversation

fogfish
Copy link
Contributor

@fogfish fogfish commented Oct 18, 2019

WHY

fixes #4592

WHAT

Use static reference

@fogfish fogfish requested a review from shivlaks as a code owner October 18, 2019 20:41
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@fogfish fogfish changed the title Use static HostedZone fix(#4592): Use static HostedZone Oct 18, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@fogfish
Copy link
Contributor Author

fogfish commented Oct 21, 2019

Are you fine with the fix?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@fogfish fogfish changed the title fix(#4592): Use static HostedZone fix(route53): Use static HostedZone Oct 22, 2019
@RomainMuller RomainMuller changed the title fix(route53): Use static HostedZone fix(route53): use static HostedZone Oct 28, 2019
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7b9503f into aws:master Oct 28, 2019
@sumodgeorge sumodgeorge mentioned this pull request May 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

@shivlaks shivlaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HostedZone.fromLookup throws exception
4 participants
@fogfish @aws-cdk-automation @RomainMuller @shivlaks