feat(ec2): Support explicit Subnet selection #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__WHY__ AWS CDK allows developers to attach subnets to other resource (e.g. ASG) using Subnets selection feature. It implies re-use of existing subnets. It is not possible to create subnet and attach it to ASG in same stack. __WHAT__ The Subnet selection feature is expanded with ability to explicitly define desired subnets. The subnet selection essentially becomes an identity funnction.
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
previously requested changes
Oct 22, 2019
|
Thanks for contributing this. Some small changes please and then it can go right in. |
|
@rix0rrr Thank you for comments! They are in. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Oct 23, 2019
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4604
WHY
AWS CDK allows developers to attach subnets to other resource (e.g. ASG)
using Subnets selection feature. It implies re-use of existing subnets.
It is not possible to create subnet and attach it to ASG in same stack.
WHAT
The Subnet selection feature is expanded with ability to explicitly
define desired subnets. The subnet selection essentially becomes an
identity funnction.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license