Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudwatch): add support for time range value #4649

Merged
merged 3 commits into from
Oct 27, 2019
Merged

feat(cloudwatch): add support for time range value #4649

merged 3 commits into from
Oct 27, 2019

Conversation

Amri91
Copy link
Contributor

@Amri91 Amri91 commented Oct 23, 2019

fixes #4647


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@Amri91 Amri91 requested a review from eladb as a code owner October 23, 2019 15:13
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Amri91 Amri91 changed the title (feat) aws-cloudwatch: add support for time range value feat(aws-cloudwatch): add support for time range value Oct 23, 2019
@eladb eladb changed the title feat(aws-cloudwatch): add support for time range value feat(cloudwatch): add support for time range value Oct 27, 2019
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0e96575 into aws:master Oct 27, 2019
njlynch added a commit that referenced this pull request May 12, 2021
The `setPeriodToTimeRange` property affects number (SingleValue), bar, and pie
charts. If set, it displays all data points in the time range in the bar/pie
chart, instead of only the most recent value. Support for this property for
`SingleValueWidget` was introduced way back in #4649, but was never added to
`GraphWidget`.
mergify bot pushed a commit that referenced this pull request May 12, 2021
The `setPeriodToTimeRange` property affects number (SingleValue), bar, and pie
charts. If set, it displays all data points in the time range in the bar/pie
chart, instead of only the most recent value. Support for this property for
`SingleValueWidget` was introduced way back in #4649, but was never added to
`GraphWidget`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
The `setPeriodToTimeRange` property affects number (SingleValue), bar, and pie
charts. If set, it displays all data points in the time range in the bar/pie
chart, instead of only the most recent value. Support for this property for
`SingleValueWidget` was introduced way back in aws#4649, but was never added to
`GraphWidget`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudWatch Widget: Support time range value
4 participants