fix(init): 'cdk init' doesn't leave .d.ts files #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cdk init` was leaving `add-project.hook.d.ts` in the .NET project directory, since that file was not matching the regex intended to catch those files. Fix that, and add a test to make sure.
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
previously requested changes
Nov 4, 2019
packages/aws-cdk/lib/init.ts
Outdated
| @@ -116,7 +116,8 @@ export class InitTemplate { | |||
| } else if (file.match(/^.*\.template\.[^.]+$/)) { | |||
| await this.installProcessed(fromFile, toFile.replace(/\.template(\.[^.]+)$/, '$1'), project); | |||
| continue; | |||
| } else if (file.match(/^.*\.hook\.[^.]+$/)) { | |||
| } else if (file.match(/^.*\.hook\.(d.)?[^.]+$/)) { | |||
| console.log(file); | |||
|
can you add Fixes #2314 to the commit body as well please :) |
RomainMuller
approved these changes
Nov 4, 2019
shivlaks
approved these changes
Nov 4, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cdk initwas leavingadd-project.hook.d.tsin the .NET projectdirectory, since that file was not matching the regex intended to
catch those files.
Fix that, and add a test to make sure.
Fixes #2314.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license