Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes file #493

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Add .gitattributes file #493

merged 1 commit into from
Aug 3, 2018

Conversation

costleya
Copy link
Contributor

@costleya costleya commented Aug 3, 2018

Add .gitattributes file to ensure compatable line endings across platforms.

Modify .gitallowed to allow all test patterns detected by git-secrets.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

…forms.

Modify .gitallowed to allow all test patterns detected by git-secrets.
@costleya costleya requested a review from a team August 3, 2018 01:23
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these should be in every module (we can easily generate/enforce via pkglint)

@costleya
Copy link
Contributor Author

costleya commented Aug 3, 2018

There needs to be one per git repository. It effects how git will check out the files from the repository, and if it will do auto-conversion when files are checked in. For example, this one says to convert CRLF files to LF on check in (to prevent someone from accidentally adding a CRLF file), and to check out all files as LF, regardless of platform.

@eladb eladb merged commit 8e619e0 into aws:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants