Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct java examples #498

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Correct java examples #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions examples/cdk-examples-java/pom.xml.t.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const mavenFromNpm = name => ({
repo: path.join(path.dirname(require.resolve(name)), 'maven-repo'),
});

const cdk = mavenFromNpm('aws-cdk-java');
const cdk = mavenFromNpm('aws-cdk');
const jsii = mavenFromNpm('jsii-java-runtime');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if it will make more sense to just use the published maven artifacts instead of generate the pom so this is iidiomatic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's basically what I'm doing here... Just figuring out the latest version numbers... Honestly this is just what I needed to fix in order to validate the maven staging artifacts... Just wanted those changes not to be lost :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move those examples to a separate repo so people can clone it and use as a basis for their app.


process.stdout.write(`
Expand All @@ -16,17 +16,6 @@ process.stdout.write(`
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>

<repositories>
<repository>
<id>cdk</id>
<url>file://${cdk.repo}</url>
</repository>
<repository>
<id>jsii</id>
<url>file://${jsii.repo}</url>
</repository>
</repositories>

<groupId>com.amazonaws.cdk</groupId>
<artifactId>cdk-examples-java</artifactId>
<version>${version}</version>
Expand Down
0 .../amazonaws/cdk/examples/HelloJavaApp.java → .../amazon/awscdk/examples/HelloJavaApp.java
View file
Open in desktop
File renamed without changes.
0 ...mazonaws/cdk/examples/HelloJavaStack.java → ...mazon/awscdk/examples/HelloJavaStack.java
View file
Open in desktop
File renamed without changes.
0 ...com/amazonaws/cdk/examples/SinkQueue.java → ...are/amazon/awscdk/examples/SinkQueue.java
View file
Open in desktop
File renamed without changes.
0 ...mazonaws/cdk/examples/SinkQueueProps.java → ...mazon/awscdk/examples/SinkQueueProps.java
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...amazonaws/cdk/examples/SinkQueueTest.java → ...amazon/awscdk/examples/SinkQueueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import software.amazon.awscdk.services.sqs.QueueProps;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.jsii.JsiiException;
import software.amazon.jsii.JsiiException;
import org.junit.Test;

import java.io.IOException;
Expand Down
0 ...xamples/testSubscribeTopics.expected.json → ...xamples/testSubscribeTopics.expected.json
View file
Open in desktop
File renamed without changes.