Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(region-info): throw exception when no fact found #5166

Merged
merged 3 commits into from
Dec 10, 2019
Merged

feat(region-info): throw exception when no fact found #5166

merged 3 commits into from
Dec 10, 2019

Conversation

stephendwu
Copy link
Contributor

  • New method that throws an exception when the Fact value, given a name and region, are not found.

closes #3194

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller
RomainMuller previously requested changes Nov 27, 2019
View reviewed changes
packages/@aws-cdk/region-info/lib/fact.ts Outdated
* @param region the name of the region (e.g: `us-east-1`)
* @param name the name of the fact being looked up (see the `FactName` class for details)
*/
public static getFact(region: string, name: string): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names starting with get are not ideal (they won't translate very cleanly in other supported languages like Java - where it'll collide with a possible future static property getter).

How about naming it require? (This is just a suggestion - if you have a better idea that doesn't start with get, that should be fine).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your suggestion, and that escaped my mind. Updated to requireFact.

@mergify mergify bot dismissed RomainMuller’s stale review November 27, 2019 19:45

Pull request has been modified.

@stephendwu stephendwu force-pushed the stephendwu/no-fact-find-throw-exception branch from 7eee215 to 03c867a Compare November 27, 2019 19:45
@stephendwu
feat(region-info): throw exception when no fact found
ad8afa2 
 * New method that throws an exception when the Fact value, given a name and region, are not found.

closes aws#3194
@stephendwu stephendwu force-pushed the stephendwu/no-fact-find-throw-exception branch from 03c867a to ad8afa2 Compare November 27, 2019 19:47
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller
RomainMuller approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool beans!

@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 88df1eb into aws:master Dec 10, 2019
ed-at-work pushed a commit to ed-at-work/aws-cdk that referenced this pull request Dec 17, 2019
@stephendwu
feat(region-info): throw exception when no fact found (aws#5166)
8b23c24 
* New method that throws an exception when the Fact value, given a name and region, are not found.

closes aws#3194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

@RomainMuller RomainMuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

region-info Fact.find() should throw exception if fact not found
3 participants
@stephendwu @aws-cdk-automation @RomainMuller