Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamodb): stacks created by GlobalTable correctly inherit their account #5202

Merged

Conversation

skinny85
Copy link
Contributor

If an account was specified on the main stack,
the child stacks created by GlobalTable were env-agnostic,
which means it wasn't possible to have a reference between a global table instance,
and anything in the main stack, even if they were in the same region.

Fixes #4882


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…account.

If an account was specified on the main stack,
the child stacks created by GlobalTable were env-agnostic,
which means it wasn't possible to have a reference between a global table instance,
and anything in the main stack, even if they were in the same region.

Fixes aws#4882
@skinny85 skinny85 requested a review from shivlaks November 27, 2019 00:25
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 27, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 5ad5407 into aws:master Nov 27, 2019
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the PR title should have describe the bug, not the solution. So basically "stacks created by global table do not inherit account"

@skinny85 skinny85 deleted the fix/dynamodb-global-stack-account-inheritance branch November 27, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure adding a stream of the DynamoDB regional table as an event source to a lambda function
4 participants