Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add Rekognition interface endpoints #5316

Merged
merged 2 commits into from
Dec 12, 2019
Merged

feat(ec2): add Rekognition interface endpoints #5316

merged 2 commits into from
Dec 12, 2019

Conversation

cmckni3
Copy link
Contributor

@cmckni3 cmckni3 commented Dec 5, 2019


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@cmckni3 cmckni3 requested a review from rix0rrr as a code owner December 5, 2019 23:01
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cmckni3
Copy link
Contributor Author

cmckni3 commented Dec 6, 2019

There is a non-fips endpoint for Rekognition as well. For some reason, the non-fips endpoint is not available in us-east-1.

@cmckni3 cmckni3 changed the title feat(ec2): Add REKOGNITION_FIPS interface endpoint feat(ec2): Add Rekognition interface endpoints Dec 6, 2019
@cmckni3
Copy link
Contributor Author

cmckni3 commented Dec 6, 2019

Added non-FIPS endpoint. Working with support on why us-east-1 does not have non-FIPS endpoint.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cmckni3
Copy link
Contributor Author

cmckni3 commented Dec 6, 2019

com.amazonaws.us-east-1.rekognition is available. I missed the second page of the pagination.

@rix0rrr rix0rrr changed the title feat(ec2): Add Rekognition interface endpoints feat(ec2): add Rekognition interface endpoints Dec 12, 2019
@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b291280 into aws:master Dec 12, 2019
ed-at-work pushed a commit to ed-at-work/aws-cdk that referenced this pull request Dec 17, 2019
@cmckni3 cmckni3 deleted the rekognition-fips-endpoint branch June 12, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants