Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecr): remove deprecated requirement on docs and comments #5428

Merged
merged 3 commits into from
Dec 16, 2019
Merged

fix(ecr): remove deprecated requirement on docs and comments #5428

merged 3 commits into from
Dec 16, 2019

Conversation

sukjae
Copy link
Contributor

@sukjae sukjae commented Dec 14, 2019 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@sukjae
docs(ecr): fix deprecated requirement maxImageAgeDays
51d30e0 
- on [Automatically clean up repositories](https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecr-readme.html\#automatically-clean-up-repositories) of Amazon ECR docs, there is deprecated property using on addLifecycleRule example
- due to introduce of Duration Class(#2857), it should be maxImageAge rather than maxImageAgeDays
@sukjae
chore(ecr): fix deprecated requirement maxImageAgeDays
ce7f4dc 
- maxImageAgeDays were deprecated since #2857, but still used on comments.
- should be chaged to maxImageAge
- fixes #3273
@sukjae sukjae requested a review from rix0rrr as a code owner December 14, 2019 10:00
@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 40ec78e into aws:master Dec 16, 2019
ed-at-work pushed a commit to ed-at-work/aws-cdk that referenced this pull request Dec 17, 2019
@sukjae
fix(ecr): remove deprecated requirement on docs and comments (aws#5428)
97e983b 
* docs(ecr): fix deprecated requirement maxImageAgeDays

- on [Automatically clean up repositories](https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecr-readme.html\#automatically-clean-up-repositories) of Amazon ECR docs, there is deprecated property using on addLifecycleRule example
- due to introduce of Duration Class(aws#2857), it should be maxImageAge rather than maxImageAgeDays

* chore(ecr): fix deprecated requirement maxImageAgeDays

- maxImageAgeDays were deprecated since aws#2857, but still used on comments.
- should be chaged to maxImageAge
- fixes aws#3273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript ECR Documentation Update
3 participants
@sukjae @aws-cdk-automation @rix0rrr