feat(custom-resources): use latest SDK in AwsCustomResource #5442
Conversation
Add a `useLatestSdk` prop to `AwsCustomResource`. When set to `true`, the latest v2 of AWS SDK JS will be installed when a new container is initialized for the Lambda function. Subsequent executions resuing this container will skip installation. Increase default timeout to 60 seconds when `useLatestSdk` is set to `true`. Closes aws#2689 Closes aws#5063
|
Could also be applied for |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| * to note that this will apply to **all** `AwsCustomResource`s in the stack | ||
| * even if only one instance sets this parameters to `true`. | ||
| * | ||
| * @default false |
There was a problem hiding this comment.
Wondering if this should be the default, because why not?
There was a problem hiding this comment.
Agree. If this is the default then the prop should be removed because to disable it it must be set to false on all AwsCusomResource?
There was a problem hiding this comment.
You mean from backwards compatibility perspective?
There was a problem hiding this comment.
I mean, do we want to offer a way to opt out from this feature because it will not be possible to opt out for some instances of AwsCustomResource only.
There was a problem hiding this comment.
Let's just make this the only behavior (remove the option to opt-out). I don't see value in using an old SDK...
There was a problem hiding this comment.
Done, added a fallback to the normal sdk (e.g. NPM unavailable).
Does this need documentation? Do you want to add this to AwsApi in @aws-cdk/aws-events-targets? In this PR?
jogold
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -149,7 +149,7 @@ export interface AwsCustomResourceProps { | |||
| /** | |||
| * The timeout for the Lambda function implementing this custom resource. | |||
| * | |||
| * @default Duration.seconds(30) | |||
| * @default Duration.seconds(60) | |||
There was a problem hiding this comment.
curious what the rationale behind the increase is? Is it only to cover the time it'll take to install the latest SDK or were there any other determining factors?
There was a problem hiding this comment.
It's indeed only to cover installation time
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Install the latest v2 of AWS SDK JS when a new container is initialized
for the Lambda function. Subsequent executions reusing this container will
skip installation.
Increase default timeout to 60 seconds.
Closes #2689
Closes #5063
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license