fix(eks): kubernetes cannot create external load balancers #5448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the tag "kubernetes.io/role/elb" to all public subnets, so Kubernetes can use these subnets when creating an external load balancer. Fixes #5443
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| for (const subnet of subnets) { | ||
| // if this is not a concrete subnet, attach a construct warning | ||
| if (!Subnet.isVpcSubnet(subnet)) { | ||
| const subnetId = Token.isUnresolved(subnet.subnetId) ? '' : subnet.subnetId; |
There was a problem hiding this comment.
If the subnet ID is a token, won't this generate a warning that is weirdly illegible?
There was a problem hiding this comment.
Let me try to improve...
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the tag "kubernetes.io/role/elb" to all public subnets, so Kubernetes can use these subnets when creating an external load balancer.
Fixes #5443
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license