Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on PR #556 #562

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Follow up on PR #556 #562

merged 1 commit into from
Aug 14, 2018

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Aug 14, 2018

  • Use node.js "crypto" module instead of md5
  • Filter out non-alphanumeric only after "Resource" is omitted
  • Remove construct.name, and fix all dependencies, including a bug discovered in the cloudtrail library that used bucket.name instead of bucket.bucketName (horray!)

BREAKING CHANGE: construct.name => construct.id

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

* Use node.js "crypto" module instead of md5
* Remove `construct.name` (and fix all dependencies)
* Remove non-alphanumeric after "Resource" is omitted

BREAKING CHANGE: `construct.name` => `construct.id`
@eladb eladb changed the title chore(cdk): Follow up on PR #556 Follow up on PR #556 Aug 14, 2018
@eladb eladb merged commit 3524bf4 into master Aug 14, 2018
@eladb eladb deleted the benisrae/construct-unique-id-followup branch August 14, 2018 16:08
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants