Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): nested stacks do not report missing context #5638

Merged
merged 2 commits into from
Jan 5, 2020

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Jan 3, 2020

Report missing context when context is not available.
Prior to this change the synthesize method return before reporting missing context when invoked on a nested stacks.
fixes #5594


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@NetaNir NetaNir requested a review from eladb as a code owner January 3, 2020 21:03
@NetaNir NetaNir requested a review from rix0rrr January 3, 2020 21:05
@NetaNir NetaNir changed the title fix(core): nested stacks does not report missing context #5594 fix(core): nested stacks does not report missing context Jan 3, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously approved these changes Jan 5, 2020
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ❤️

@eladb eladb changed the title fix(core): nested stacks does not report missing context fix(core): nested stacks do not report missing context Jan 5, 2020
@eladb eladb self-assigned this Jan 5, 2020
@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot dismissed eladb’s stale review January 5, 2020 08:27

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb merged commit 9472e09 into master Jan 5, 2020
@eladb eladb deleted the neta/fix-nested-stacks-missing-context branch January 5, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] availabilityZones with account and region specified not working in nested stacks
3 participants