Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(s3-deployment): remove console output of source hash #5664

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jan 6, 2020

Otherwise every single cdk command outputs the source hash when
BucketDeployment is used in one of the stacks.

Something like:

{
  sourceHash: '6416c21be320b522db64c705872c0a54d788e3df57b34a5f0d1e8602d7521430'
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Otherwise every single `cdk` command outputs the source hash when
`BucketDeployment` is used in one of the stacks.

Something like:
```
{
  sourceHash: '6416c21be320b522db64c705872c0a54d788e3df57b34a5f0d1e8602d7521430'
}
```
@jogold jogold requested a review from eladb as a code owner January 6, 2020 14:54
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously approved these changes Jan 7, 2020
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embarrassing

@mergify mergify bot dismissed eladb’s stale review January 7, 2020 10:50

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 8, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 8, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit f5aee01 into aws:master Jan 8, 2020
@jogold jogold deleted the s3-deploy-no-console branch January 24, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants