chore(cli): fix Java dist integ tests #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Java integ test which is run against the dist is failing because the local `cdk-cx-api` Maven artifact cannot be found. Error message: ``` [ERROR] Failed to execute goal on project cdk-init-test: Could not resolve dependencies for project com.myorg:cdk-init-test:jar:0.1: Failed to collect dependencies at software.amazon.awscdk:core:jar:1.20.0 -> software.amazon.awscdk:cdk-cx-api:jar:[1.20.0]: No versions available for software.amazon.awscdk:cdk-cx-api:jar:[1.20.0] within specified range -> [Help 1] ``` It is not clear to me why just this artifact cannot be found while for example `core` can be found correctly, or why this problem only shows up on the `release` branch, but after some reading of the Maven source and local experimentation I have concluded that the proper filename of the Maven metadata file should be `maven-metadata-local.xml` (instead of just `maven-metadata.xml`), so we rename the files before rsync'ing them into the repository now.
rix0rrr
requested review from
RomainMuller,
skinny85,
eladb,
NetaNir and
nija-at
|
I'm aware that my sourcing for this "fix" is specious, but it does seem to solve the issue. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
|
Oh this should have gone into "release" |
rix0rrr
added a commit
that referenced
this pull request
Jan 7, 2020
The Java integ test which is run against the dist is failing because the local `cdk-cx-api` Maven artifact cannot be found. Error message: ``` [ERROR] Failed to execute goal on project cdk-init-test: Could not resolve dependencies for project com.myorg:cdk-init-test:jar:0.1: Failed to collect dependencies at software.amazon.awscdk:core:jar:1.20.0 -> software.amazon.awscdk:cdk-cx-api:jar:[1.20.0]: No versions available for software.amazon.awscdk:cdk-cx-api:jar:[1.20.0] within specified range -> [Help 1] ``` It is not clear to me why just this artifact cannot be found while for example `core` can be found correctly, or why this problem only shows up on the `release` branch, but after some reading of the Maven source and local experimentation I have concluded that the proper filename of the Maven metadata file should be `maven-metadata-local.xml` (instead of just `maven-metadata.xml`), so we rename the files before rsync'ing them into the repository now.
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2020
The Java integ test which is run against the dist is failing because the local `cdk-cx-api` Maven artifact cannot be found. Error message: ``` [ERROR] Failed to execute goal on project cdk-init-test: Could not resolve dependencies for project com.myorg:cdk-init-test:jar:0.1: Failed to collect dependencies at software.amazon.awscdk:core:jar:1.20.0 -> software.amazon.awscdk:cdk-cx-api:jar:[1.20.0]: No versions available for software.amazon.awscdk:cdk-cx-api:jar:[1.20.0] within specified range -> [Help 1] ``` It is not clear to me why just this artifact cannot be found while for example `core` can be found correctly, or why this problem only shows up on the `release` branch, but after some reading of the Maven source and local experimentation I have concluded that the proper filename of the Maven metadata file should be `maven-metadata-local.xml` (instead of just `maven-metadata.xml`), so we rename the files before rsync'ing them into the repository now.
nija-at
added a commit
that referenced
this pull request
Jan 8, 2020
* v1.20.0 * chore(cli): fix Java dist integ tests (#5695) (#5699) The Java integ test which is run against the dist is failing because the local `cdk-cx-api` Maven artifact cannot be found. Error message: ``` [ERROR] Failed to execute goal on project cdk-init-test: Could not resolve dependencies for project com.myorg:cdk-init-test:jar:0.1: Failed to collect dependencies at software.amazon.awscdk:core:jar:1.20.0 -> software.amazon.awscdk:cdk-cx-api:jar:[1.20.0]: No versions available for software.amazon.awscdk:cdk-cx-api:jar:[1.20.0] within specified range -> [Help 1] ``` It is not clear to me why just this artifact cannot be found while for example `core` can be found correctly, or why this problem only shows up on the `release` branch, but after some reading of the Maven source and local experimentation I have concluded that the proper filename of the Maven metadata file should be `maven-metadata-local.xml` (instead of just `maven-metadata.xml`), so we rename the files before rsync'ing them into the repository now. * remove breaking change that didn't really happen * chore: fixup entries in the CHANGELOG (#5706) Co-authored-by: Rico Huijbers <rix0rrr@gmail.com> Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java integ test which is run against the dist is failing because
the local
cdk-cx-apiMaven artifact cannot be found. Error message:It is not clear to me why just this artifact cannot be found while for
example
corecan be found correctly, or why this problem only shows upon the
releasebranch, but after some reading of the Maven source andlocal experimentation I have concluded that the proper filename of the
Maven metadata file should be
maven-metadata-local.xml(instead ofjust
maven-metadata.xml), so we rename the files before rsync'ing theminto the repository now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license