docs: corrected format in preferredMaintenanceWindow #5697
Conversation
Updated documentation for preferredMaintenanceWindow to match requirements (was previously displaying incorrect format based on backup window docs)
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Thanks for the contribution @rushimusmaximus ! One tiny thing to change. Plus, can you make sure your PR title and commit description adheres to conventional commits? Thanks!
| @@ -102,11 +102,9 @@ export interface DatabaseClusterProps { | |||
| readonly kmsKey?: kms.IKey; | |||
|
|
|||
| /** | |||
| * A daily time range in 24-hours UTC format in which backups preferably execute. | |||
| * A preferred maintenance window day/time range. Should be specified as a range ddd:hh24:mi-ddd:hh24:mi (24H Clock UTC). | |||
There was a problem hiding this comment.
You need to remove the trailing space (it's what made the build fail) 🙂
rushimusmaximus
changed the title
Updated documentation for preferredMaintenanceWindow to match requirements (was previously displaying incorrect format based on backup window docs)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@skinny85 Thanks for the feedback. I think the pull request is ready to merge now. |
|
Thanks @rushimusmaximus , merged! |
Updated documentation for preferredMaintenanceWindow to match requirements (was previously displaying incorrect format based on backup window docs)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license