Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudformation): nested stack example in readme is broken #5729

Merged
merged 4 commits into from
Jan 9, 2020
Merged

fix(cloudformation): nested stack example in readme is broken #5729

merged 4 commits into from
Jan 9, 2020

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jan 9, 2020

Use this instead of scope and make props optional.

Fixes #5686

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

fix(cloudformation): nested stack example in readme is broken
b6f39e7 
Use `this` instead of `scope` and make `props` optional.

Fixes #5686
@eladb eladb mentioned this pull request Jan 9, 2020
Closed
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit c53356a into master Jan 9, 2020
@mergify mergify bot deleted the eladb-patch-1 branch January 9, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested stacks must be defined within scope of another non-nested stack error when using cfn.NestedStack
3 participants
@eladb @aws-cdk-automation @rix0rrr