chore(cx-api): clean up features.ts #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up features.ts such that it will include only things related to feature flags in order to make it easier for users to discover and add feature flags in one place. Merged it with the contents of `future.ts` and updates contribution guide to that end. The other context keys that were in `feature.ts` were not actually feature flags but rather application switches, so these were moved to `app.ts`. Fixes #6098
|
🚫 Features must contain a change to a README file |
eladb
changed the title
eladb
requested review from
aws-cdk-automation and
a team
and removed request for
aws-cdk-automation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
approved these changes
Feb 11, 2020
|
Thank you for contributing! Your pull request is now being automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up features.ts such that it will include only things related to feature flags in order to make it easier for users to discover and add feature flags in one place. Merged it with the contents of
future.tsand updates contribution guide to that end.The other context keys that were in
feature.tswere not actually feature flags but rather application switches, so these were moved toapp.ts.Fixes #6098
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license