Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appsync): don't retain dynamodb tables #6401

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

duarten
Copy link
Contributor

@duarten duarten commented Feb 22, 2020

Correctly tear down the tables created in the context of the test.

Signed-off-by: Duarte Nunes duarte@uma.ni


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Correctly tear down the tables created in the context of the test.

Signed-off-by: Duarte Nunes <duarte@uma.ni>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5092ae5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@duarten
Copy link
Contributor Author

duarten commented Mar 4, 2020

Ping.

@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f9cb35a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2117374 into aws:master Mar 4, 2020
eladb pushed a commit that referenced this pull request Mar 9, 2020
Correctly tear down the tables created in the context of the test.

Signed-off-by: Duarte Nunes <duarte@uma.ni>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
horsmand pushed a commit to horsmand/aws-cdk that referenced this pull request Mar 9, 2020
Correctly tear down the tables created in the context of the test.

Signed-off-by: Duarte Nunes <duarte@uma.ni>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@duarten duarten deleted the feature/no-table-retention branch February 17, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants