Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): optional master secret in DatabaseSecret #6415

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Feb 24, 2020

Add an optional masterSecret prop in DatabaseSecret and clarify documentation
for the multi user rotation schema.

Related to #6358


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add an optional `masterSecret` prop in `DatabaseSecret` and clarify documentation
for the multi user rotation schema.

Related to aws#6358
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b254c42
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold jogold changed the title feat(rds): master secret in DatabaseSecret feat(rds): optional master secret in DatabaseSecret Feb 24, 2020
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 86ab557
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b660e29
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit a9e5b60 into aws:master Feb 26, 2020
@jogold jogold deleted the rds-master-secret branch February 26, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants