Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigatewayv2): http api #6432
feat(apigatewayv2): http api #6432
Changes from 10 commits
d310726
bef371a
2ba95d8
9f08ed4
075e564
febd6a3
33dead4
02f96c2
46d3be4
7265479
35b8ddf
66c5022
87fbe4b
d26ad33
4b278c0
bef8974
068b476
6f8f64d
9d986d5
d338c41
32b6a31
b200c9f
0bea7fc
822cfe8
c20a448
b6415e3
1965f59
6547860
0989585
330b4af
90204bb
818af1d
3568779
7b64fd0
bb8857f
5f44349
9e4deb8
35d6341
cce22c1
edba63c
0b404dc
d9cd335
a5e2b20
48aa1af
ea8bea9
c18a7d0
113053d
8ded78b
df21f0f
b808736
7cc71e0
64606f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop backquotes for HTTP APIs and Lambda Proxy Integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has not been addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop backquote for 'Routes' and 'default route'. Use backquotes only when referring to something that's programmatic - either a classname, method name, property name, a tiny piece of code (such as GET /pets, as you've done)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this statement. It's a detail of the implementation and does not seem relevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add two lines one declaring the HTTP API and the other declaring the lambda function (as shown in a previous comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is mandatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
apiName
is a mandatory property ofHttpApiProps
then when wenew HttpApi()
we always need to specify anapiName
for it. Is it correct?I noticed the
restApiName
is optional. Did I miss something?aws-cdk/packages/@aws-cdk/aws-apigateway/lib/restapi.ts
Lines 67 to 72 in 5dc1407
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't clear.
The
Name
parameter inApiGatewayv2::Api
is mandatory (unless an OpenAPI definition is provided).What is it going to be in the case that a user does not specify it? The CDK has to set some value here, correct? The
@default
annotation says the ID of theHttpApi
construct, but that isn't available at the time of construction ofCfnApi
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this should be named
httpApiName
.