feat(contributors): use 0.0.0 as a version marker

pack.sh

@@ -57,8 +57,14 @@ done
 # Remove a JSII aggregate POM that may have snuk past
 rm -rf dist/java/software/amazon/jsii
 
-# Get version from lerna
-version="$(cat ${root}/lerna.json | grep version | cut -d '"' -f4)"
+# Get version
+version="$(node -p "require('./scripts/get-version')")"
+
+# Ensure we don't publish anything beyond 1.x for now
+if [[ ! "${version}" == "1."* ]]; then
+  echo "ERROR: accidentally releasing a major version? Expecting repo version to start with '1.' but got '${version}'"
+  exit 1
+fi
 
 # Get commit from CodePipeline (or git, if we are in CodeBuild)
 # If CODEBUILD_RESOLVED_SOURCE_VERSION is not defined (i.e. local
@@ -79,6 +85,16 @@ HERE
 # copy CHANGELOG.md to dist/ for github releases
 cp CHANGELOG.md ${distdir}/
 
+# defensive: make sure our artifacts don't use the version marker (this means
+# that "pack" will always fails when building in a dev environment)
+# when we get to 10.0.0, we can fix this...
+marker=$(node -p "require('./scripts/get-version-marker')")
+if find dist/ | grep "${marker}"; then
+  echo "ERROR: build artifacts use the version marker '${marker}' instead of a real version."
+  echo "This is expected for builds in a development environment but should not happen in CI builds!"
+  exit 1
+fi
+
 # for posterity, print all files in dist
 echo "=============================================================================================="
 echo " dist contents"

scripts/align-version.js

@@ -4,14 +4,14 @@
 //
 const fs = require('fs');
 
-const marker = '999.0.0';
+const marker = require('./get-version-marker');
 const repoVersion = require('./get-version');
 
 for (const file of process.argv.splice(2)) {
   const pkg = JSON.parse(fs.readFileSync(file).toString());
 
   if (pkg.version !== marker) {
-    throw new Error(`unexpected - all package.json files in this repo should have a version of 999.0.0: ${file}`);
+    throw new Error(`unexpected - all package.json files in this repo should have a version of ${marker}: ${file}`);
   }
 
   pkg.version = repoVersion;

scripts/align-version.sh

@@ -13,7 +13,8 @@ files="$(find . -name package.json | grep -v node_modules | xargs)"
 ${scriptdir}/align-version.js ${files}
 
 # validation
-if find . -name package.json | grep -v node_modules | xargs grep "999.0.0"; then
-  echo "ERROR: unexpected version marker 999.0.0 in a package.json file"
+marker=$(node -p "require('./scripts/get-version-marker')")
+if find . -name package.json | grep -v node_modules | xargs grep "${marker}"; then
+  echo "ERROR: unexpected version marker ${marker} in a package.json file"
   exit 1
 fi

scripts/get-version-marker.js

@@ -0,0 +1,13 @@
+/**
+ * Returns the version marker used to indicate this is a local dependency.
+ *
+ * Usage:
+ *
+ *    const version = require('./get-version-marker');
+ *
+ * Or from the command line:
+ *
+ *    node -p require('./get-version-marker')
+ *
+ */
+module.exports = '0.0.0';